-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(tui): add session_list_limit for session picker (#6137) #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(tui): add session_list_limit for session picker (#6137) #6138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a configurable message_limit option to control the number of messages loaded per session in the TUI. The default value remains 100, but users can now configure it up to 10,000 messages through the config file.
- Add
message_limitconfiguration field to TUI schema with validation constraints (1-10,000) - Update implementation to use the configured value with fallback to 100
- Generate corresponding TypeScript type definitions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/sdk/openapi.json |
Adds message_limit field to the schema with integer constraints (1-10,000) and description |
packages/sdk/js/src/v2/gen/types.gen.ts |
Generated TypeScript types for the new message_limit config option |
packages/sdk/js/src/gen/types.gen.ts |
Generated TypeScript types with incorrect default value in documentation |
packages/opencode/src/config/config.ts |
Adds Zod schema validation for message_limit with proper constraints |
packages/opencode/src/cli/cmd/tui/context/sync.tsx |
Updates message loading to use configured limit with fallback to 100 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f0fea03 to
0a0b93e
Compare
|
Fixed the inconsistent default value in the SDK types (was 500, now correctly 100). Thanks Copilot! |
0a0b93e to
9f54237
Compare
|
Fixed second hardcoded |
|
I have a working implementation ready - typechecks pass. |
|
@CasualDeveloper I also want to see this feature. I've had a half-finished PR in my pocket for a while that addresses this (and also makes the length of I cordially invite you to steal anything you think might be useful from my unfinished PR: ariane-emory#43 The team may (or may not) conclude that this also resolves my original Issue on the topic, #4918. |
9f54237 to
c22ee69
Compare
|
@ariane-emory Thanks for linking your PR! I've incorporated |
ef4a090 to
4a4438c
Compare
|
Re-committed with valid GPG signature. PR ready. |
4596a07 to
da1e0bc
Compare
872e100 to
1e84d56
Compare
|
Will continue rebasing on top of release tags as they're set. |
1e84d56 to
0414034
Compare
7caecd4 to
bee3fbf
Compare
|
I ran this branch to solve a problem that I have (Fork an old message). Works perfect thnks! |
bee3fbf to
7fca3b2
Compare
f4cc1aa to
c6bc16b
Compare
Revised:
|
9ee7ca8 to
6ca4fe0
Compare
|
@CasualDeveloper Might be prudent to revise the top/initial message and the title to accurately reflect the new state/scope of the PR? I was pretty confused when I came to look at the code and didn't see the setting named in the title. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Updated the PR title/body to reflect the new scope (session_list_limit only). Thanks for the nudge, @ariane-emory! |
46bf927 to
061fae0
Compare
Adds session_list_limit config option to limit sessions displayed in the session list dialog (default: 150). Limit only applies when not searching; search uses server-side limit of 30. Remove message_limit as it conflicts with cursor-based pagination (anomalyco#8535) and is now redundant.
061fae0 to
df8ff11
Compare
Summary
session_list_limitfor the session picker (default 150)Notes
message_limithas been removed; cursor-based pagination (feat(session): bi-directional cursor-based pagination (#6548) #8535) now covers message historyTesting
bun run --cwd packages/opencode typecheckCloses #6137 and maybe also #4918