fix(desktop): add single-instance protection to prevent multiple app spawns #6926
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Results✅ No duplicate PRs found The searches returned only the PR #6926 itself (which is the PR being analyzed). No other open PRs are addressing:
Conclusion: This PR appears to be unique and addresses a new issue. It's safe to proceed without concerns about duplicates. |
…nce protection Two fixes for the desktop app spawning orphaned processes: 1. Add tauri-plugin-single-instance to prevent multiple app instances from running simultaneously. When a second instance is launched, the existing window is focused instead of spawning a new process. 2. Kill the sidecar process on startup timeout before exiting. Previously, if the sidecar failed to start within 7 seconds, the app would exit but leave the spawned sidecar process running as an orphan. This would accumulate orphaned processes each time the app was launched and failed. Root cause: When the sidecar fails to start (e.g., due to module errors), the app would exit without cleaning up, leaving the process running. Repeated launch attempts would spawn more orphaned processes.
usvimal
force-pushed
the
fix/desktop-single-instance
branch
from
c74fa02 to
39e85ff
Compare
Contributor
|
Closing as we merged #6966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tauri-plugin-single-instanceto prevent multiple desktop app instancesProblem
Opening the OpenCode desktop app would spawn orphaned
opencode-cli serveprocesses that accumulate over time, even from a single launch attempt. Users reported 100+ orphaned processes consuming system resources.Root Cause
When the sidecar fails to start within 7 seconds (e.g., due to module loading errors like the
@tarquinen/opencode-dcpBun compatibility issue), the app would:app.exit(1)Each failed launch attempt would leave another orphaned process. The random port allocation (
TcpListener::bind("127.0.0.1:0")) meant each orphan ran on a different port.Solution
child.kill()before showing the failure dialog and exitingtauri-plugin-single-instanceto prevent concurrent launches (secondary fix)Changes
packages/desktop/src-tauri/Cargo.toml: Addedtauri-plugin-single-instance = "2"packages/desktop/src-tauri/src/lib.rs: