-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat: expose acp thinking variants #9064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: expose acp thinking variants #9064
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
/review |
|
thanks! |
|
@rekram1-node ready for your re-review! |
|
@rekram1-node btw been using and there's no stability problem whatsoever! i have found an another bug on opencode acp though, gonna fix it after this merged |
What does this PR do?
Fixes #8973 by exposing thinking variants in ACP model selection:
claude-sonnet-4/high) tomodels.availableModelssession/set_modelselections and keeps session variant in sync_meta(modelId,variant,availableVariants) instead of empty object@agentclientprotocol/sdkto 0.13.0How did you verify your code works?
bun run typechecksession/set_modelresponses include correct_meta.opencodewith variant infoScreenshot