fix(ui): prevent Enter key action during IME composition #9564
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isComposing check to avoid triggering selection during IME input confirmation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where pressing Enter to confirm IME (Input Method Editor) composition in search fields also triggers list item selection. The fix adds isComposing checks to Enter key handlers to distinguish between IME confirmation and actual Enter key presses.
Changes:
- Added
!event.isComposingcheck to Enter key handler inuse-filtered-listhook - Added
!e.isComposingcheck to Enter key handler inListcomponent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui/src/hooks/use-filtered-list.tsx | Added isComposing check to prevent Enter key from triggering selection during IME composition in the filtered list hook |
| packages/ui/src/components/list.tsx | Added isComposing check to prevent Enter key from triggering selection during IME composition in the List component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where pressing Enter to confirm IME (Input Method Editor) composition also triggers list item selection.
How did you verify your code works?
bun dev -- --port 4096in the root folderbun run --cwd packages/app devin the root folder in another terminal, open the local web app