fix: add timeout to Query.close() to prevent CPU hang (#378) #477
+70
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Query.close()Problem
The
Query.close()method could hang indefinitely when tasks in the anyio task group didn't properly respond to cancellation (issue #378). This caused anyio's_deliver_cancellation()to spin at 100% CPU.Affected scenarios:
client.disconnect()Solution
Set a deadline on the task group's own cancel scope during close():
This approach avoids cancel scope nesting issues that occur when wrapping with
anyio.move_on_after()oranyio.fail_after().Configuration
A new environment variable
CLAUDE_CODE_TASK_GROUP_CLOSE_TIMEOUT(milliseconds, default 5000) allows users to adjust the timeout if needed.Test plan
Closes #378