Hide subprocess terminal window on Windows #489
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, spawning a subprocess creates a visible console window by default. This change adds the CREATE_NO_WINDOW flag when spawning the Claude CLI subprocess on Windows, which hides the terminal window and improves the user experience, especially for GUI applications. The fix applies to both the main subprocess spawn in connect() and the version check subprocess in _check_claude_version(). Fixes #480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, spawning a subprocess creates a visible console window by default. This change adds the
CREATE_NO_WINDOWflag when spawning the Claude CLI subprocess on Windows, which hides the terminal window and improves the user experience, especially for GUI applications.Changes
subprocess.CREATE_NO_WINDOWflag for Windows subprocess spawningconnect()and_check_claude_version()subprocess callsTesting
Fixes #480