Added new split option #5748
Open
Added new split option #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm currently working on #5733 which will have split points be computed in a completely new way. This might make some of these changes obsolete, will just have to figure that out when we come to it. |
Contributor
Author
|
Okay, we can hold off on this one until #5733 is finished |
kevinrr888
reviewed
Jul 23, 2025
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitPointUtil.java
Outdated
Show resolved
Hide resolved
Member
I wouldn't say we have to hold off, if this looks good then it could be merged in. |
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
Tablets no longer split int he tablet server, so this change is bringing back code from 2.1 in way that is incorrect and incomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #5100
I brought back some of the old logic from 2.1 for splitting tablets with excessive files. I created a utility class to handle to handle the old batching logic to split the tablets. Withing
TabletI added the logic on if tablets should be split or not.