Removes the need for the LockWatcherWrapper #5857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the LockWatcher interface and switches to using the AccumuloLockWatcher. Removes the need for a LockWatcherWrapper Adds a boolean to track lockAcquired state. Made boolean outside of watcher to follow original LockWatcherWrapper implementation.
Contributor
Author
|
Need to refactor the method names for the interface. They should be descriptive of the various expected states for a watcher and lock. |
Contributor
|
I looked over this and I think it's ok to take out of draft. |
test/src/main/java/org/apache/accumulo/test/functional/ZombieTServer.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/lock/ServiceLockSupport.java
Show resolved
Hide resolved
Switched lockAcquired to false if failed to acquire lock. Renamed isFailedToAquireLock to cannotRetryLocking.
core/src/main/java/org/apache/accumulo/core/lock/ServiceLockSupport.java
Outdated
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
Outdated
Show resolved
Hide resolved
test/src/main/java/org/apache/accumulo/test/performance/NullTserver.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the LockWatcher interface and switches to using the AccumuloLockWatcher.
Removes the need for a LockWatcherWrapper
Adds a boolean to track lockAcquired state. Made boolean outside of watcher to follow original LockWatcherWrapper implementation.