Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ public void setup() throws Exception {
if (!Files.isDirectory(folder2)) {
Files.createDirectories(folder2);
}
Path propsFile2 = folder2.resolve("accumulo2.properties");
Path propsFile2 = folder2.resolve("org/apache/accumulo/core/accumulo2.properties");
FileUtils.copyURLToFile(
Objects.requireNonNull(this.getClass().getResource("/accumulo2.properties")),
Objects.requireNonNull(
this.getClass().getResource("/org/apache/accumulo/core/accumulo2.properties")),
propsFile2.toFile());
uri2 = propsFile2.toUri().toURL();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ public class CredentialProviderTokenTest {
justification = "keystoreUrl location isn't provided by user input")
@BeforeAll
public static void setup() throws Exception {
URL keystoreUrl = CredentialProviderTokenTest.class.getResource("/passwords.jceks");
URL keystoreUrl =
CredentialProviderTokenTest.class.getResource("/org/apache/accumulo/core/passwords.jceks");
assertNotNull(keystoreUrl);
keystorePath = "jceks://file/" + Path.of(keystoreUrl.toURI()).toAbsolutePath();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

public class ClientContextTest {

private static final String keystoreName = "/site-cfg.jceks";
private static final String keystoreName = "/org/apache/accumulo/core/site-cfg.jceks";

// site-cfg.jceks={'ignored.property'=>'ignored', 'instance.secret'=>'mysecret',
// 'general.rpc.timeout'=>'timeout'}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ public class HadoopCredentialProviderTest {

private static final Configuration hadoopConf = new Configuration();

private static final String populatedKeyStoreName = "/accumulo.jceks";
private static final String emptyKeyStoreName = "/empty.jceks";
private static final String populatedKeyStoreName = "/org/apache/accumulo/core/accumulo.jceks";
private static final String emptyKeyStoreName = "/org/apache/accumulo/core/empty.jceks";
private static File emptyKeyStore;
private static File populatedKeyStore;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ public class SiteConfigurationTest {
@Test
public void testOnlySensitivePropertiesExtractedFromCredentialProvider()
throws SecurityException {
URL keystore = SiteConfigurationTest.class.getResource("/site-cfg.jceks");
URL keystore =
SiteConfigurationTest.class.getResource("/org/apache/accumulo/core/site-cfg.jceks");
assertNotNull(keystore);
String credProvPath = "jceks://file" + Path.of(keystore.getFile()).toAbsolutePath();

Expand Down Expand Up @@ -68,7 +69,8 @@ public void testDefault() {
@Test
public void testFile() {
System.setProperty("DIR", "/tmp/test/dir");
URL propsUrl = getClass().getClassLoader().getResource("accumulo2.properties");
URL propsUrl =
getClass().getClassLoader().getResource("org/apache/accumulo/core/accumulo2.properties");
var conf = new SiteConfiguration.Builder().fromUrl(propsUrl).build();
assertEquals("myhost123:2181", conf.get(Property.INSTANCE_ZK_HOST));
assertEquals("mysecret", conf.get(Property.INSTANCE_SECRET));
Expand Down
38 changes: 19 additions & 19 deletions src/build/ci/check-module-package-conventions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ ALLOWED=(
server/native/src/main/resources/NOTICE

# TODO: these test classes should be moved into the correct package for the module
start/src/test/java/test/HelloWorldTemplate
start/src/test/java/test/TestTemplate
start/src/test/java/test/Test.java
# start/src/test/java/test/HelloWorldTemplate
# start/src/test/java/test/TestTemplate
# start/src/test/java/test/Test.java
test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterConfiguration.java
test/src/main/java/org/apache/accumulo/harness/conf/AccumuloMiniClusterConfiguration.java
test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java
Expand All @@ -55,23 +55,23 @@ ALLOWED=(
test/src/main/java/org/apache/accumulo/harness/TestingKdc.java

# TODO: these test resources should be moved into the correct package for the module
core/src/test/resources/accumulo.jceks
core/src/test/resources/empty.jceks
core/src/test/resources/site-cfg.jceks
core/src/test/resources/accumulo2.properties
core/src/test/resources/passwords.jceks
# core/src/test/resources/accumulo.jceks
# core/src/test/resources/empty.jceks
# core/src/test/resources/site-cfg.jceks
# core/src/test/resources/accumulo2.properties
# core/src/test/resources/passwords.jceks
minicluster/src/test/resources/FooFilter.jar
server/tserver/src/test/resources/walog-from-15.walog
server/tserver/src/test/resources/walog-from-16.walog
server/tserver/src/test/resources/walog-from-14/550e8400-e29b-41d4-a716-446655440000
server/tserver/src/test/resources/walog-from-20.walog
test/src/main/resources/v2_import_test/README.md
test/src/main/resources/v2_import_test/data/A0000008.rf
test/src/main/resources/v2_import_test/data/A0000009.rf
test/src/main/resources/v2_import_test/data/A000000a.rf
test/src/main/resources/v2_import_test/data/A000000b.rf
test/src/main/resources/v2_import_test/data/distcp.txt
test/src/main/resources/v2_import_test/data/exportMetadata.zip
# server/tserver/src/test/resources/walog-from-15.walog
# server/tserver/src/test/resources/walog-from-16.walog
# server/tserver/src/test/resources/walog-from-14/550e8400-e29b-41d4-a716-446655440000
# server/tserver/src/test/resources/walog-from-20.walog
# test/src/main/resources/v2_import_test/README.md
# test/src/main/resources/v2_import_test/data/A0000008.rf
# test/src/main/resources/v2_import_test/data/A0000009.rf
# test/src/main/resources/v2_import_test/data/A000000a.rf
# test/src/main/resources/v2_import_test/data/A000000b.rf
# test/src/main/resources/v2_import_test/data/distcp.txt
# test/src/main/resources/v2_import_test/data/exportMetadata.zip

# TODO: these minicluster classes should be moved into the correct package for the module
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package test;
package org.apache.accumulo.start;

public interface Test {

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
====
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
====
Comment on lines +1 to +18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header will break. The exception in the pom.xml needs to be updated instead of adding a license header to this data file.

Other exceptions/exclusions statements in the pom.xml files should be checked and updated, as needed, for any other moved files as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to wait on the files in harness as well since they also since they also seem to affect a lot of our test?


hdfs://localhost:8020/accumulo/tables/1/default_tablet/A000000b.rf
hdfs://localhost:8020/accumulo/tables/1/t-0000002/A000000a.rf
hdfs://localhost:8020/accumulo/tables/1/t-0000001/A0000009.rf
hdfs://localhost:8020/accumulo/tables/1/t-0000003/A0000008.rf
hdfs://localhost:8020/accumulo/export_test/exportMetadata.zip
5 changes: 0 additions & 5 deletions test/src/main/resources/v2_import_test/data/distcp.txt

This file was deleted.

Loading