Use RowRange in place of Range for tablet availability API #5952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrr888
reviewed
Oct 9, 2025
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Show resolved
Hide resolved
keith-turner
approved these changes
Nov 20, 2025
| * portion of the start and end Keys and the inclusivity parameters are used when determining the | ||
| * range of affected tablets. The other portions of the start and end Keys are not used. | ||
| * for the tablets to reach this availability state. The supplied row range is compared against | ||
| * the tablets' start/end rows using its lower/upper bounds and inclusivity flags; any non-row |
Contributor
There was a problem hiding this comment.
Is this still needed any non-row portions of the keys are ignored. ?
Member
Author
There was a problem hiding this comment.
Yea good catch I guess using RowRange makes that explicit here so we don't need to explain it.
Removed redundant information about non-row portions of keys in the Javadoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TableOperationsmethodsgetandsetTabletAvailabilityaccepted aRangeas a parameter but only treated it as a range of rows. The changes in this PR make that intent more explicit and use a more specific type as the input param.