Fix nondeterministic behavior in testPrettyPrint by making iterator assertions order-independent #5962
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Dec 5, 2025
| assertTrue(pp.contains("condition: " + FAMILY + ":" + QUALIFIER + " value: " + VALUE | ||
| + " iterator: '" + iters[0] + "' '" + iters[1] + "'")); | ||
| assertTrue(pp.contains("condition: " + FAMILY + ":" + QUALIFIER + " value: " + VALUE)); | ||
| String iterSection = pp.substring(pp.indexOf("iterator:")); |
Contributor
There was a problem hiding this comment.
I'm curious if this is a false positive as the iters object is an array, which is ordered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is fixing a nondeterministic test failure in ConditionalMutationTest.testPrettyPrint() when running with Nondex.
Problem
The original test checked for a single concatenated string that included both iterators’ data in a specific order. This caused nondeterministic failures under NonDex, since the order of iterators is not guaranteed.
Reproduce Test
The Fix
Instead of asserting one long expected string that assumes a fixed iterator sequence, the updated test now extracts the
iteratorsection and individually checks each iterator’s:This ensures the test verifies the logical presence of all expected iterator properties,
regardless of their order in the output string.