adds function to compute load plans when splits are unknown #5982
+118
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Nov 24, 2025
Comment on lines
542
to
546
| CryptoService cs = | ||
| CryptoFactoryLoader.getServiceForClient(CryptoEnvironment.Scope.TABLE, properties); | ||
| CachableBlockFile.CachableBuilder cb = | ||
| new CachableBlockFile.CachableBuilder().fsPath(fs, path).conf(conf).cryptoService(cs); | ||
| try (var reader = new org.apache.accumulo.core.file.rfile.RFile.Reader(cb)) { |
Contributor
There was a problem hiding this comment.
Is there a reason not to use FileOperations.ReaderBuilder?
Contributor
Author
There was a problem hiding this comment.
Not sure, I will look into that. I think I copied this code from somewhere (maybe the Rfile print info code) that was doing what I needed.
Contributor
Author
There was a problem hiding this comment.
Updated in a10cd12 to use FileOperations
Co-authored-by: Dave Marion <dlmarion@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5971