set scan executor names for meta and root #5987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomGarguilo
reviewed
Nov 21, 2025
| ScanDispatch.builder().setExecutorName("root").build(); | ||
| private static final ScanDispatch META_SCAN_DISPATCH = | ||
| ScanDispatch.builder().setExecutorName("meta").build(); | ||
|
|
||
| public void executeReadAhead(KeyExtent tablet, ScanDispatcher dispatcher, ScanSession<?> scanInfo, | ||
| Runnable task) { | ||
|
|
||
| task = ScanSession.wrap(scanInfo, task); | ||
|
|
||
| if (tablet.isRootTablet()) { | ||
| // TODO make meta dispatch?? |
Member
There was a problem hiding this comment.
Not changed in this PR but do you happen to know what these TODO comments mean?
Contributor
Author
There was a problem hiding this comment.
For user tables plugins can dispatch their scans to different executors. For the metadata and root tablets it hard coded which executors they will use for scans. Those comments are about those diffs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root and metadata table scans were not setting scan executor names. This information will be needed by #5986