Fixed Coordinator treating compaction cancellation like failure #6019
Conversation
The Coordinator in 2.1 checks the exception class name and if it is not null, then treats it as a failure. In 2.1 when a compaction is cancelled, null is passed. In main null was removed from the Compactor and InterruptedException was used in it's place. However the Coordinator code was not updated and was still treating it as a failure because the exception class name is not null. Fixed this check such that it's only treated as a failure if the class name is not the InterruptedException class name. Closes apache#6018
|
The way the compactor communicates cancellation is hidden and its brittle, makes it easier for someone to accidentally break these comms on the client or server side w/o realizing it. We could make communicating this more visible with a new RPC specifically for compaction cancelled. Or we could add a thrift enum to the existing failure RPC to specify the reason for the failure like ERROR or CANCELLATION. |
Good idea, I'll look at adding a Thrift enum. |
2 participants
The Coordinator in 2.1 checks the exception class name and if it is not null, then treats it as a failure. In 2.1 when a compaction is cancelled, null is passed.
In main null was removed from the Compactor and InterruptedException was used in it's place. However the Coordinator code was not updated and was still treating it as a failure because the exception class name is not null. Fixed this check such that it's only treated as a failure if the class name is not the InterruptedException class name.
Closes #6018