Improve timekeeping code #6041
Merged
Improve timekeeping code #6041
+156
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Jan 8, 2026
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
Made a couple of comments about using Duration.dividedBy and Duration.multipliedBy to avoid extra object creation instead of doing those operations on primitives.
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
Outdated
Show resolved
Hide resolved
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Jan 8, 2026
| long currentNanos = System.nanoTime(); | ||
| if ((currentNanos - lastRun) >= threshold) { | ||
| Duration threshold = Duration.ofMillis(maxAgeMillis.getAsLong() / 2); | ||
| if (threshold.compareTo(minInterval) < 0) { |
Contributor
There was a problem hiding this comment.
Guava has Comparators.min and Comparators.max that could be used like the existing code uses Math.min and Math.max. These changes are fine though, just pointing those out in case you were not aware.
Member
Author
There was a problem hiding this comment.
Thanks for pointing that out, I did not know of those. As I was writing this code I was wondering why there wasn't an equivalent for Duration variables but never looked into it.
Added in 17dd12d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes to several files that:
Durationvslong