Improve duplex network wait conditions and ports#1669
Open
jeanouii wants to merge 4 commits intoapache:mainfrom
Open
Improve duplex network wait conditions and ports#1669jeanouii wants to merge 4 commits intoapache:mainfrom
jeanouii wants to merge 4 commits intoapache:mainfrom
Conversation
jeanouii
force-pushed
the
fix/network-duplex-wait-ports
branch
from
127a88d to
a31b321
Compare
Contributor
|
This looks pretty good but same comment as #1674 , maybe it's easier to just get rid of all the spring config for the tests entirely? |
Contributor
|
It looks like SimpleNetworkTest failed, is that something related? |
jeanouii
force-pushed
the
fix/network-duplex-wait-ports
branch
from
a31b321 to
da6aff0
Compare
Contributor
Author
|
I've updated the PR but it fails in a different test everytime. So I'm trying again. I don't think it was related, but I'll see if I can make it green for more confidence. |
jeanouii
force-pushed
the
fix/network-duplex-wait-ports
branch
from
5b1de31 to
4ea67dc
Compare
…stNetworkTest to use what's in the XML for now
… it's no longer needed
jeanouii
force-pushed
the
fix/network-duplex-wait-ports
branch
from
ada8780 to
ebbc12f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.