GH-1007: fix: does not break class loading if direct buffer allocator is not available#1008
Open
torito wants to merge 5 commits intoapache:mainfrom
Open
GH-1007: fix: does not break class loading if direct buffer allocator is not available#1008torito wants to merge 5 commits intoapache:mainfrom
torito wants to merge 5 commits intoapache:mainfrom
Conversation
torito
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Author
|
I'm not able to set the |
Author
|
@lidavidm can you review this please |
Member
|
@torito I gonna take a look. By the way, I'm fixing the CI, so the build for this PR will probably fail. |
Member
|
@torito can you please rebase this PR ? The CI should be ok now. |
torito
force-pushed
the
catch-jpms-failure
branch
from
115e465 to
b002db5
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The Direct Buffer is not always needed to use Arrow memory, however, we cannot load MemoryUtil class if we don't set:
Which is not always needed/possible.
This fix proposes to catch the
InaccessibleObjectExceptionto not avoiding the load of the class.The directBuffer is, in any case not available and a
UnsupportedOperationExceptionwill be throw as it is in the existing codeCloses #1007 .