MINOR: Fix broken Linux JNI build #764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
requested review from
jbonofre,
kou,
laurentgo and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
I think this was due to apache/arrow@1229ced.
kou
reviewed
May 23, 2025
| cmake \ | ||
| -S "${source_dir}" \ | ||
| -B "${build_dir}" \ | ||
| -DARROW_VCPKG="${ARROW_VCPKG}" \ |
Member
There was a problem hiding this comment.
Can we use ARROW_DEPENDENCY_SOURCE=VCPKG instead? It sets ARROW_VCPKG internally.
Member
Author
There was a problem hiding this comment.
I tried this and it doesn't seem to work: I don't think the Java JNI CMake code has anything to detect this. Also, Findutf8proc.cmake installed by Arrow's CMake checks ARROW_VCPKG, but I don't see any other code installed to set this.
Member
There was a problem hiding this comment.
Ah, OK. I'll fix it in apache/arrow.
Member
Author
|
After apache/arrow#46564 I re-ran the job on main and it passes now, so I'm closing this. Thanks Kou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
I think this was due to apache/arrow@1229ced.
We need to explicitly set ARROW_VCPKG=ON for Linux builds so that Findutf8proc.cmake does the right thing.