GH-399: Check for null writers in DenseUnionWriter#setPosition #938
+91
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added null checks for setPosition and test cases to validate the issue
Kaustav-Sarkar
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
Kaustav-Sarkar
changed the title
This comment has been minimized.
This comment has been minimized.
Author
|
I do not have permissions to set labels |
lidavidm
reviewed
Dec 25, 2025
Member
There was a problem hiding this comment.
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestDenseUnionWriterNPE { |
Member
There was a problem hiding this comment.
nit: JUnit 5 doesn't require declaring everything public
| } | ||
|
|
||
| @Test | ||
| public void testListOfDenseUnionWriterNPE() { |
Member
There was a problem hiding this comment.
Link back to the issue
Suggested change
| public void testListOfDenseUnionWriterNPE() { | |
| public void testListOfDenseUnionWriterNPE() { | |
| // Regression test for ... |
lidavidm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-399 Fix setPosition fails with NullPointerException
Fixed a
NullPointerExceptioninDenseUnionWriter#setPosition.The issue was that
setPositiontried to update all writers in its internal array, even if they hadn't been initialized yet. I added a null check so it only updates writers that actually exist.Also added a regression test (
TestDenseUnionWriterNPE) to verify the fix and updated.gitignore.Closes #399.