GH-46217: [C++][Parquet] Update the timestamp of parquet::encryption::TwoLevelCacheWithExpiration correctly #46283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapoisu
changed the title
|
|
kou
approved these changes
May 2, 2025
cpp/src/parquet/encryption/two_level_cache_with_expiration_test.cc
Outdated
Show resolved
Hide resolved
adamreeve
approved these changes
May 2, 2025
github-actions
bot
added
awaiting committer review
Contributor
Author
|
I'll try to see if I can fix the error during CI. It seems similar to #46203. |
adamreeve
reviewed
May 4, 2025
Contributor
Author
wgtmac
changed the title
wgtmac
approved these changes
May 6, 2025
Member
|
I've rebased on git main and will merge if CI is ok. |
* RemoveExpiredEntriesFromCache didn't update the timestamp while it should. If it did, it would literally be CheckCacheForExpiredTokens(0.0). I've added a default value to CheckCacheForExpiredTokens to make it more natural and removed RemoveExpiredEntriesFromCache. * Update the call sites accordingly.
Member
|
@kapoisu Sorry for forgetting about this! I rebased again and then merged. Thank you for your contribution! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit eda9942. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix the bug mentioned in #46217 (comment)
What changes are included in this PR?
Are these changes tested?
Yes. The original test didn't expose the problem because CheckCacheForExpiredTokens was only called once.
Are there any user-facing changes?
No.