GH-48725: [C++] Fix bundled Protobuf doesn't exist in libarrow_bundled_dependencies #48726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bundled_dependencies
|
|
Member
Author
|
Worked in apache/arrow-java: https://github.com/apache/arrow-java/actions/runs/20740904802/job/59547364091?pr=925 I'll merge this. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4f1cac1. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Member
|
Thanks @kou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to update
ARROW_BUNDLED_STATIC_LIBSin the parent scope because GH-48183 changed tofunction(build_protobuf)frommacro(build_protobuf).What changes are included in this PR?
Update
ARROW_BUNDLED_STATIC_LIBSin the parent scope.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.