GH-48774: [CI] Only cancel in-progress builds for pull requests, not main branch #48775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
Member
Author
|
Ohh ok it was my bad It is already covered by group!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, workflows use
cancel-in-progress: trueunconditionally, which cancels builds even on the main branch when multiple commits are pushed in quick succession. This prevents proper validation of main branch commits and can cause incomplete CI runs for scheduled builds.TBD
What changes are included in this PR?
Changed
cancel-in-progressfromtrueto${{ github.event_name == 'pull_request' }}in workflows.Now only pull request builds are cancelled when new commits are pushed. Main branch pushes, scheduled runs, and manual runs will always complete.
Are these changes tested?
Will be tested in CI.
Are there any user-facing changes?
No, dev-only.