Skip to content

Conversation

@hjtran
Copy link
Contributor

@hjtran hjtran commented Oct 3, 2025

If a module imports from __future__ imports annotations, any function we try to get type hints from using typing.decorators.get_signature returns Any. This is because the future import causes all typehints to become strings (to postpone evaluation) and get_signature doesn't know how to resolve postponed typehint strings.

This diff extends get_signature so it actually resolves these annotations.

I tried to keep the get_signature behavior consistent between both modes (import from future and not importing from future), so I just created a generation script to clone the typehints_test and decorators_test but with the future import.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant