CAMEL-19329: Migrate MavenDownloaderImpl to use MIMA (Minimal Maven)#21450
Draft
gnodet wants to merge 3 commits intoapache:mainfrom
Draft
CAMEL-19329: Migrate MavenDownloaderImpl to use MIMA (Minimal Maven)#21450gnodet wants to merge 3 commits intoapache:mainfrom
gnodet wants to merge 3 commits intoapache:mainfrom
Conversation
gnodet
force-pushed
the
CAMEL-migrate-maven-downloader-to-mima
branch
from
f98da5f to
890e7f3
Compare
Contributor
|
great! I trust your PR - I can look on Monday at how did you do it ;) |
- Replace manual Maven Resolver setup with MIMA library - Remove DIRegistry and manual DI configuration (~650 lines) - Reduce MavenDownloaderImpl from 1,240 to 649 lines (48% reduction) - Add MIMA dependencies (context, embedded-maven, standalone-static) - Remove individual maven-resolver-* dependencies - Preserve all existing functionality: - Dual mode operation (embedded Maven plugin + standalone) - Repository configuration (Maven Central, Apache Snapshots, custom repos) - Settings.xml and settings-security.xml processing - Offline mode, fresh mode, repository resolver - Download listeners and custom timeout configuration - Update MavenVersionManager and ValidateMojo to use new constructor - Delete obsolete DIRegistry, DIRegistryTest, and MavenResolverTest
gnodet
force-pushed
the
CAMEL-migrate-maven-downloader-to-mima
branch
from
890e7f3 to
6265db7
Compare
Contributor
|
Just out of curiosity - did you generate these MD files using AI or did you write these to control AI? |
Contributor
Author
They were AI generated, but shouldn't have been integrated in the PR, I removed those. |
Contributor
|
this is good to be based on that mina project - jbang have switched over as well. The hardcoded version should be a placeholder from parent/pom.xml |
grgrzybek
approved these changes
Feb 13, 2026
Croway
approved these changes
Feb 13, 2026
Contributor
|
@gnodet the PR fails with: looks like there's no transitive dependency on plexus-cipher, but be careful with https://repo1.maven.org/maven2/org/codehaus/plexus/plexus-cipher/ - in codehaus-plexus/plexus-cipher@176289f they added hardcoded iteration count to 310000 and the tests take ages to finish. |
…e root cause traversal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ader Two issues fixed: 1. MIMA runtime selection: prefer standalone-static runtime over embedded-maven when in standalone mode. The embedded-maven runtime shares the Maven build's session which can cause artifact resolution conflicts during tests. 2. ExportSpringBoot: fall back to camelVersion when camelSpringBootVersion is null for catalog loading. Previously, null camelSpringBootVersion caused CatalogLoader to fall back to the classpath SNAPSHOT version, which may not be available in remote repos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
MavenDownloaderImplfrom manual Maven Resolver setup to MIMA (Minimal Maven) 2.4.39, significantly simplifying the codebase while preserving all functionality.