Conversation
added 2 commits
May 27, 2020 12:13
Member
Author
|
request docbuild |
Member
Author
|
request docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr131 Build Log Output: No log errors found to report. |
andrijapanicsb
approved these changes
May 29, 2020
Contributor
|
I like the green colour though... |
source/releasenotes/about.rst
Outdated
| also be an issue on Shared Networks which are using Internet routable/public (i.e. non-RFC1918) | ||
| IP addresses as the DNS service is then queriable from the public internet at large. A new | ||
| global setting "expose.dns.externally" has been added (with a default value of "true" in | ||
| order to keep backward compatibility) which limits the source of DNS queries to hosts on the |
Contributor
There was a problem hiding this comment.
Suggested change
| order to keep backward compatibility) which limits the source of DNS queries to hosts on the | |
| order to keep backward compatibility) which does not limit the source of DNS queries to hosts on the |
Member
Author
There was a problem hiding this comment.
Yes, I see your point, i've reworded to be clearer.
yadvr
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve information to external DNS note and reformat line widths.