VM ingestion by shwstppr · Pull Request #84 · apache/cloudstack-documentation

shwstppr · 2019-11-18T08:01:07Z

Documentation PR for VM Ingestion feature.
Feature PR: apache/cloudstack#3606

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr · 2019-11-18T08:12:26Z

source/adminguide/virtual_machines.rst

+-  listUnmanagedInstances - to list unmanaged virtual machines for a cluster.
+
+-  importUnmanagedInstance - to import an unmanaged virtual machine into CloudStack.
+


@shwstppr add details on how to use the .py script etc?

@rhtyd yes, will be adding that. This was just initial commit to create PR, working on rest of the documentation

shwstppr · 2019-11-18T08:48:59Z

@andrijapanicsb @PaulAngus Can you please review changes
I'm not sure if it is the correct location in documentation to add vm ingestion notes so please advise changes needed.
Also, advise on the format. Since this is my first documentation PR I'm not sure if added notes, API details correctly.

PaulAngus · 2019-11-18T15:28:05Z

requesting docbuild

ACSGitBot · 2019-11-18T15:28:13Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2019-11-18T15:29:50Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

typo fix

shwstppr · 2019-12-02T05:37:09Z

requesting docbuild

ACSGitBot · 2019-12-02T05:37:18Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2019-12-02T05:38:42Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

and separate "importing VMs" into a separate file.

PaulAngus · 2020-01-13T10:43:28Z

requesting docbuild

ACSGitBot · 2020-01-13T10:43:34Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2020-01-13T10:44:59Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

PaulAngus · 2020-01-15T09:18:52Z

requesting docbuild

ACSGitBot · 2020-01-15T09:18:58Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2020-01-15T09:20:39Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84

Build Log Output:

No log errors found to report.

shwstppr

Some minor suggestions @PaulAngus

source/adminguide/virtual_machines/VM_Ingestion.rst

shwstppr · 2020-01-15T11:59:25Z

source/adminguide/virtual_machines/VM_Ingestion.rst

+###############
+
+
+To import a VM which has data disks attached, a map of the disk ID and corresponding disk offering ID must be passed via the *datadiskofferinglist* parameter.


@PaulAngus We also have diskofferingid parameter for specifying offering for root disk so do we need to mention that here.

oh boy, what happens in code? the diskoffering is a messy subject, a user doesn't choose a disk offering for the root, it's linked to the serviceoffering ID

While importing it uses disk offeering passedc with param diskofferingid. It is a required parameter for importUnmanagedInstance API

hmm. if you consider creating a VM from a template, you don't pass a disk offering, it's implicit from the service offering...

source/adminguide/virtual_machines/VM_Ingestion.rst

Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2020-03-17T09:15:22Z

requesting docbuild

ACSGitBot · 2020-03-17T09:15:31Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2020-03-17T10:34:01Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84

Build Log Output:

No log errors found to report.

andrijapanicsb · 2020-05-13T13:54:16Z

@shwstppr Can you please update this one:

there is conflict
it mentioned Backup and Recovery, but there is actually a separate B&R PR [WIP] Backup & Recovery Doc Guide #85
can you sync with Rohit and see what is what and to have this one (VM ingestion) merged.

PaulAngus · 2020-05-13T13:59:16Z

if you merge B&R, the commits will match.
B&R was used as the basis for this to avoid conflicts

andrijapanicsb · 2020-05-13T14:04:34Z

@PaulAngus are you saying that this one is reviewed and LGTM?

PaulAngus · 2020-05-13T14:40:26Z

@shwstppr it doesn't look like you've updated this PR after review by Steve Roles ..?

shwstppr · 2020-05-13T14:46:16Z

@PaulAngus I don't think Steve ever reviewed this one. There was no draft word doc for it. After initial updates it was mostly updated by you.

shwstppr · 2020-05-13T15:05:48Z

@andrijapanic will resolve the conflict tomorrow morning

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2020-05-14T09:42:51Z

@andrijapanicsb I've fixed conflicts. cc @PaulAngus

andrijapanicsb · 2020-05-14T09:45:11Z

requesting docbuild

ACSGitBot · 2020-05-14T09:45:15Z

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot · 2020-05-14T09:47:28Z

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr84

Build Log Output:

No log errors found to report.

andrijapanicsb · 2020-05-21T17:48:57Z

@shwstppr @PaulAngus - can you advise if this is good to go or not, we need it asap for 4.14.
thx

source/adminguide/virtual_machines/VM_Ingestion.rst

andrijapanicsb · 2020-05-23T14:19:17Z

pinging again for LGTM if possible.

andrijapanicsb · 2020-05-25T08:53:26Z

Merging as it is, looks LGTM in general, but we can always improve it if needed.
Required for 4.14 to go out.

initial commit

6bc261b

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr reviewed Nov 18, 2019

View reviewed changes

shwstppr added 2 commits November 18, 2019 14:04

added import VM details

997901a

fix formatting

bd1e3b8

shwstppr mentioned this pull request Nov 18, 2019

VM ingestion apache/cloudstack#3606

Merged

5 tasks

shwstppr changed the title ~~[WIP DO NOT MERGE] VM Ingestion~~ [WIP DO NOT MERGE] VM ingestion Nov 18, 2019

added notes for network discovery script

a46dd5e

ipAddress key to ip4Address

a9bbf70

typo fix

yadvr added 3 commits December 9, 2019 00:35

b&R doc wip

a7f80af

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

changes

541fc1e

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

newline fixes

419bd10

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added the feature New feature or request label Dec 29, 2019

PaulAngus added 4 commits January 3, 2020 17:36

WIP adding B&R and a bit working with VMs refactoring

d735e05

More configuration instructions

1275e48

fix heading heirarchy

27a55a7

Merge branch 'backup-recovery-doc' into feature-vm-ingestion

2fd3e0d

and separate "importing VMs" into a separate file.

PaulAngus added 2 commits January 14, 2020 07:57

incremental addition to vm ingestion

e8b961a

more information about VM ingestion.

7a9cbf4

shwstppr commented Jan 15, 2020

View reviewed changes

Paul Angus and others added 3 commits January 15, 2020 14:10

Update source/adminguide/virtual_machines/VM_Ingestion.rst

edfb3e6

Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

Update source/adminguide/virtual_machines/VM_Ingestion.rst

ea3a13d

Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

Update source/adminguide/virtual_machines/VM_Ingestion.rst

302db81

Co-Authored-By: Abhishek Kumar <abhishek.mrt22@gmail.com>

PaulAngus changed the title ~~[WIP DO NOT MERGE] VM ingestion~~ VM ingestion and B&R Jan 30, 2020

PaulAngus changed the title ~~VM ingestion and B&R~~ VM ingestion May 13, 2020

Merge branch 'master' into feature-vm-ingestion

2541c61

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

andrijapanicsb reviewed May 21, 2020

View reviewed changes

source/adminguide/virtual_machines/VM_Ingestion.rst Outdated Show resolved Hide resolved

Update source/adminguide/virtual_machines/VM_Ingestion.rst

c6d1761

andrijapanicsb merged commit 95b7382 into apache:master May 25, 2020

		- listUnmanagedInstances - to list unmanaged virtual machines for a cluster.

		- importUnmanagedInstance - to import an unmanaged virtual machine into CloudStack.

		###############


		To import a VM which has data disks attached, a map of the disk ID and corresponding disk offering ID must be passed via the datadiskofferinglist parameter.

Conversation

shwstppr commented Nov 18, 2019

Uh oh!

yadvr Nov 18, 2019

Choose a reason for hiding this comment

Uh oh!

shwstppr Nov 18, 2019

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Nov 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulAngus commented Nov 18, 2019

Uh oh!

ACSGitBot commented Nov 18, 2019

Uh oh!

ACSGitBot commented Nov 18, 2019

Uh oh!

shwstppr commented Dec 2, 2019

Uh oh!

ACSGitBot commented Dec 2, 2019

Uh oh!

ACSGitBot commented Dec 2, 2019

Uh oh!

PaulAngus commented Jan 13, 2020

Uh oh!

ACSGitBot commented Jan 13, 2020

Uh oh!

ACSGitBot commented Jan 13, 2020

Uh oh!

PaulAngus commented Jan 15, 2020

Uh oh!

ACSGitBot commented Jan 15, 2020

Uh oh!

ACSGitBot commented Jan 15, 2020

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shwstppr Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

PaulAngus Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

shwstppr Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

PaulAngus Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Mar 17, 2020

Uh oh!

ACSGitBot commented Mar 17, 2020

Uh oh!

ACSGitBot commented Mar 17, 2020

Uh oh!

andrijapanicsb commented May 13, 2020

Uh oh!

PaulAngus commented May 13, 2020

Uh oh!

andrijapanicsb commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulAngus commented May 13, 2020

Uh oh!

shwstppr commented May 13, 2020

Uh oh!

shwstppr commented May 13, 2020

Uh oh!

shwstppr commented May 14, 2020

Uh oh!

andrijapanicsb commented May 14, 2020

Uh oh!

ACSGitBot commented May 14, 2020

Uh oh!

ACSGitBot commented May 14, 2020

shwstppr commented Nov 18, 2019 •

edited

Loading

andrijapanicsb commented May 13, 2020 •

edited

Loading