Fix infinite update loop for optional zone fields #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Computed: true to optional zone fields that are set by the Read function. This prevents Terraform from detecting false drift when these fields are not explicitly set in the configuration but have values returned by the CloudStack API. Fields fixed: - guest_cidr_address - dns2 - internal_dns2 - ip6_dns1 - ip6_dns2 The issue occurred because these fields were Optional but not Computed. When a user removed a previously set value from their config, Terraform would: 1. Expect the field to be null (not in config) 2. Read a non-null value from the API 3. Detect drift and plan to remove it 4. Send an update with the field omitted 5. CloudStack would retain the old value (no explicit clear) 6. Loop back to step 2 With Optional + Computed, Terraform accepts API-provided values even when not explicitly set in the configuration, breaking the update loop.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an infinite update loop that occurs when users remove previously configured optional zone fields from their Terraform configuration. The fix adds Computed: true to five optional zone fields, allowing Terraform to accept API-provided values even when not explicitly set in the configuration.
- Adds
Computed: trueto optional zone fields that are populated by the CloudStack API - Prevents false drift detection when fields are not explicitly set in user configuration
- Aligns with existing patterns used for other optional fields in the same resource
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Computed: trueto optional zone fields that are set by the Read function. This prevents Terraform from detecting false drift when these fields are not explicitly set in the configuration but have values returned by the CloudStack API.Fields fixed:
guest_cidr_addressdns2internal_dns2ip6_dns1ip6_dns2The issue occurred because these fields were Optional but not Computed. When a user removed a previously set value from their config, Terraform would:
With Optional + Computed, Terraform accepts API-provided values even when not explicitly set in the configuration, breaking the update loop.