Removed unnecessary @Local annotations and their respective imports#1102
Merged
asfgit merged 1 commit intoapache:masterfrom Nov 23, 2015
Merged
Conversation
…rom the ComponentLifecycleBase class and its subclasses.
Contributor
Contributor
|
LGTM, checked the code. It felt like skimming at times as 607 lines were removed ;) I don't think there is any problem though. |
asfgit
pushed a commit
that referenced
this pull request
Nov 23, 2015
…-006 Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code. I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes). * pr/1102: Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses. Signed-off-by: Remi Bergsma <github@remi.nl>
Contributor
|
@cristofolini github doesn't show JuniperSRXExternalFirewallElement. It has a syntax error. Did you compile this? and did you use -Dnoredist? that part would have probably revealed the error. I am busy creating a fix |
Member
|
@DaanHoogland, Sorry for the trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code.
I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes).