engine-schema: fix systemvm template upgrade for missing or unused hypervisor type

[shwstppr]

Description

Fixes #12077

Consider hosts instead of clusters to get the list of hypervisor and architecture combinations.
Improve checking bundled system vm templates.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.27%. Comparing base (d26122b) to head (9e387f9).
⚠️ Report is 111 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java	63.63%	3 Missing and 1 partial ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12092      +/-   ##
============================================
+ Coverage     16.18%   16.27%   +0.08%     
- Complexity    13305    13432     +127     
============================================
  Files          5657     5661       +4     
  Lines        498459   500018    +1559     
  Branches      60492    60716     +224     
============================================
+ Hits          80694    81362     +668     
- Misses       408783   409584     +801     
- Partials       8982     9072      +90     

Flag	Coverage Δ
uitests	4.15% <ø> (+0.14%)	⬆️
unittests	17.12% <58.33%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16741

[DaanHoogland]

we are removing hyperv and ovm3. also; is there an Extension hypervisor type?

[shwstppr]

@DaanHoogland currently we cannot run system VMs with External hypervisor.
I checked we do have system templates for HyperV and OVM here, https://download.cloudstack.org/systemvm/4.22/

I can remove LXC for now and remaining when they are removed or in main

[DaanHoogland]

ok, just add. there is a removal PR out on main and we’ll have to add the removal there (pun just a happy accident).