server: add options for kvm.guest.os.machine.type

[weizhouapache]

Description

This PR fixes an issue that there is no option for kvm guest os machine type in the dropdown on UI
the setting was introduced by #11569

Thanks @rajujith reporting the issue

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (031fbf4) to head (3c2f8fe).
⚠️ Report is 69 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12414   +/-   ##
=========================================
  Coverage     17.59%   17.59%           
- Complexity    15596    15600    +4     
=========================================
  Files          5910     5910           
  Lines        529755   529756    +1     
  Branches      64724    64724           
=========================================
+ Hits          93218    93228   +10     
+ Misses       426045   426036    -9     
  Partials      10492    10492           

Flag	Coverage Δ
uitests	3.60% <ø> (ø)
unittests	18.66% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@blueorangutan package

[weizhouapache]

cc @rajujith @DaanHoogland @nvazquez
can you review ?

[rajujith]

@blueorangutan package

[blueorangutan]

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16373

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[nvazquez]

LGTM - thanks @weizhouapache @rajujith

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16375

[vishesh92]

clgtm

[rajujith]

@weizhouapache The option added is passed to KVM but its not useful in my use case yet due to incorrect controller type set for q35 machine type:

[resource.wrapper.LibvirtStartCommandWrapper] (AgentRequest-Handler-2:[]) (logid:feb005a8) LibvirtException org.libvirt.LibvirtException: unsupported configuration: IDE controllers are unsupported for this QEMU binary or machine type at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.Connect.domainCreateXML(Unknown Source) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:2241)

<type arch='x86_64' machine='pc-q35-rhel9.6.0'>hvm</type>

--
--
<disk device='cdrom' type='file'>
  <driver name='qemu' type='raw' />
  <source file=''/>
  <target dev='hdc' bus='ide'/>
</disk>

rootDiskController=scsi
cc @nvazquez

[Damans227]

Tested the PR against a lab environment. The kvm.guest.os.machine.type option now appears in both template and VM settings dropdowns and works as expected.

[Damans227]

LGTM

[harikrishna-patnala]

@weizhouapache The option added is passed to KVM but its not useful in my use case yet due to incorrect controller type set for q35 machine type:

[resource.wrapper.LibvirtStartCommandWrapper] (AgentRequest-Handler-2:[]) (logid:feb005a8) LibvirtException org.libvirt.LibvirtException: unsupported configuration: IDE controllers are unsupported for this QEMU binary or machine type at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.ErrorHandler.processError(Unknown Source) at org.libvirt.Connect.domainCreateXML(Unknown Source) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:2241)

<type arch='x86_64' machine='pc-q35-rhel9.6.0'>hvm</type>

--
--
<disk device='cdrom' type='file'>
  <driver name='qemu' type='raw' />
  <source file=''/>
  <target dev='hdc' bus='ide'/>
</disk>

rootDiskController=scsi cc @nvazquez

@rajujith I've added a new issue based on your comment #12535. I think we merge this PR as it is intended to add the setting only.

[harikrishna-patnala]

LGTM