Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR fixes the license inconsistency in SearchFilter.vue.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.20.3 milestone Jan 30, 2026
@sureshanaparti sureshanaparti marked this pull request as draft January 30, 2026 08:08
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (25eacaa) to head (8a3c958).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12554   +/-   ##
=========================================
  Coverage     16.26%   16.26%           
+ Complexity    13428    13427    -1     
=========================================
  Files          5660     5660           
  Lines        499914   499914           
  Branches      60696    60696           
=========================================
+ Hits          81318    81320    +2     
  Misses       409523   409523           
+ Partials       9073     9071    -2     
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 17.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishesh92
Copy link
Member

included these changes in #12553

@vishesh92 vishesh92 closed this Jan 30, 2026
@DaanHoogland DaanHoogland deleted the precommit-license-SearchFilter-vue branch January 30, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants