-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: Fix api method to getAPI in SearchFilter.vue #12558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Conversation
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates API method calls in SearchFilter.vue from the deprecated api function to the new getAPI and postAPI functions, aligning with changes introduced in PR #10899 which adds support for enforcing POST requests on state-changing APIs.
Changes:
- Updated import statement to use
getAPIandpostAPIinstead ofapi - Replaced 4
api()calls with appropriategetAPI()orpostAPI()calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12558 +/- ##
============================================
- Coverage 17.62% 17.62% -0.01%
Complexity 15666 15666
============================================
Files 5915 5915
Lines 531098 531098
Branches 64921 64921
============================================
- Hits 93599 93598 -1
Misses 426964 426964
- Partials 10535 10536 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
this does not look good in QA, checking to see if this is a 21 vs 22 issue. @blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16652 |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16653 |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
This PR fixes api calls in SearchFilter added in 4.20. The API methods were changed from api to getAPI & postAPI. This PR updates the same for
SearchFilter.vue.#10899
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?