Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Jan 30, 2026

Description

This PR fixes the template details deletion while updating template from UI.

Fixes #12456

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Updated rootdiskcontoller for the template (having some existing details) from UI.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (25eacaa) to head (99c06e0).
⚠️ Report is 3 commits behind head on 4.20.

Files with missing lines Patch % Lines
...che/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 0.00% 2 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12559      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13428    13428              
============================================
  Files          5660     5660              
  Lines        499914   499955      +41     
  Branches      60696    60706      +10     
============================================
+ Hits          81318    81319       +1     
- Misses       409523   409563      +40     
  Partials       9073     9073              
Flag Coverage Δ
uitests 4.16% <ø> (-0.01%) ⬇️
unittests 17.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12559 (QA-JID-866)

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Existing Template Settings are deleted when an Update Template api is executed

3 participants