-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix template details deletion while updating template from UI #12559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Fix template details deletion while updating template from UI #12559
Conversation
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12559 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
Complexity 13428 13428
============================================
Files 5660 5660
Lines 499914 499955 +41
Branches 60696 60706 +10
============================================
+ Hits 81318 81319 +1
- Misses 409523 409563 +40
Partials 9073 9073
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16655 |
Description
This PR fixes the template details deletion while updating template from UI.
Fixes #12456
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Updated rootdiskcontoller for the template (having some existing details) from UI.
How did you try to break this feature and the system with this change?