Refactor CLI perfomance command to avoid future allocations #1608
+93
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allocation a single Future for every parse/unparse done during the CLI performance command, this instead allocate creates one Future per performance thread. All files to parse are added to a ConcurrentLinkedQueue and the consumer Future read from this queue until empty. This also no longer stores the results of each parse/unparse run, instead just keeping tracking of the number of files processes and the average latency. This changes avoid allocations during the performance command. In testing, this does not seem to affect the performance results in any meaningful way, but it does reduce allocations which makes profiling a bit cleaner. DAFFODIL-3064
olabusayoT
approved these changes
Jan 6, 2026
Contributor
olabusayoT
left a comment
olabusayoT
left a comment
There was a problem hiding this comment.
+1. Minor labeling update
| } | ||
| val totalTimeSec = totalTimeNS.toDouble / 1_000_000_000 | ||
| val averageThroughput = (totalFiles.toDouble / totalTimeSec) | ||
| val averageLatency = (totalLatencyNS.toDouble / totalFiles / 1_000_000) |
Contributor
There was a problem hiding this comment.
Would it be clearer to label these averages with Sec/MS, NBD if not.
Also refactor to simiplify logic as much as possible, avoids the Either and match/case and the Timer functions that can allocation lambdas. This likely doesn't have any affect on performance, but in a critical loop it makes sense to be as efficient as possible and this does not add much complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allocation a single Future for every parse/unparse done during the CLI performance command, this instead allocate creates one Future per performance thread. All files to parse are added to a ConcurrentLinkedQueue and the consumer Future read from this queue until empty.
This also no longer stores the results of each parse/unparse run, instead just keeping tracking of the number of files processes and the average latency.
This changes avoid allocations during the performance command. In testing, this does not seem to affect the performance results in any meaningful way, but it does reduce allocations which makes profiling a bit cleaner.
DAFFODIL-3064