-
Notifications
You must be signed in to change notification settings - Fork 263
fix: Improve logic for adding CopyExec operators to prevent memory corruption from mutable buffer reuse #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2135 +/- ##
============================================
+ Coverage 56.12% 58.47% +2.34%
- Complexity 976 1253 +277
============================================
Files 119 143 +24
Lines 11743 13202 +1459
Branches 2251 2371 +120
============================================
+ Hits 6591 7720 +1129
- Misses 4012 4257 +245
- Partials 1140 1225 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2131
Closes #1836
Rationale for this change
CopyExec::UnpackOrDeepCopyinto a plan was complex to maintain and is only needed for the soon to be legacynative_cometscan. It is not needed for thenative_datafusionornative_iceberg_compatscans. This PR simplifies the implementation so that the deep copy logic happens directly inScanExec. This is likely slightly less performance than before fornative_cometscans.What changes are included in this PR?
has_buffer_reuseflag toScanExecprotobufScanExecif this flag is enablednative_cometscan and Iceberg scans (which currently wrapnative_comet)native_cometscansFilterExec, which was a slightly modified fork of DataFusion'sFilterExec. This is no longer needed now that we copy the incoming batches before the filter.How are these changes tested?
I will wait for #1987 to be merged and then make sure that this PR does not introduce any regressions.