Skip to content

Conversation

@hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Aug 20, 2025

Which issue does this PR close?

Closes #. #2118

Rationale for this change

What changes are included in this PR?

In Iceberg's 1.8.1.diff, orderBy("id") -> orderBy("id", "data")

How are these changes tested?

Tested passed locally w/ spark.comet.exec.shuffle.mode=jvm and spark.comet.exec.shuffle.mode=native

@hsiang-c hsiang-c changed the title fix: order query result deterministically fix: [iceberg] order query result deterministically Aug 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.55%. Comparing base (f09f8af) to head (d710388).
⚠️ Report is 400 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2208      +/-   ##
============================================
+ Coverage     56.12%   58.55%   +2.42%     
- Complexity      976     1283     +307     
============================================
  Files           119      143      +24     
  Lines         11743    13216    +1473     
  Branches       2251     2363     +112     
============================================
+ Hits           6591     7738    +1147     
- Misses         4012     4250     +238     
- Partials       1140     1228      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove merged commit 8e02012 into apache:main Aug 21, 2025
94 of 95 checks passed
@hsiang-c hsiang-c deleted the order_query_result branch August 21, 2025 16:24
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants