Skip to content

Conversation

@hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Aug 21, 2025

Which issue does this PR close?

Closes #. #2119

Rationale for this change

What changes are included in this PR?

ORDER BY t1.id, t1.%s -> ORDER BY t1.id, t1.%s, t1.salary

How are these changes tested?

Tested locally with .config("spark.comet.exec.shuffle.mode", "jvm") and .config("spark.comet.exec.shuffle.mode", "native")

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.48%. Comparing base (f09f8af) to head (209ac40).
⚠️ Report is 405 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2210      +/-   ##
============================================
+ Coverage     56.12%   58.48%   +2.36%     
- Complexity      976     1273     +297     
============================================
  Files           119      143      +24     
  Lines         11743    13216    +1473     
  Branches       2251     2363     +112     
============================================
+ Hits           6591     7730    +1139     
- Misses         4012     4253     +241     
- Partials       1140     1233      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
Copy link
Member

This fix was included in #2205. Thanks @hsiang-c

@andygrove andygrove closed this Aug 22, 2025
@hsiang-c hsiang-c deleted the order_query_result_2 branch August 22, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants