Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 8, 2025

Which issue does this PR close?

Partially implements #1926 (supports arrays but not maps)

Rationale for this change

size is a widely used SQL function in Spark.

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (f09f8af) to head (cb25861).
⚠️ Report is 783 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/scala/org/apache/comet/serde/arrays.scala 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2862      +/-   ##
============================================
+ Coverage     56.12%   59.61%   +3.48%     
- Complexity      976     1381     +405     
============================================
  Files           119      167      +48     
  Lines         11743    15502    +3759     
  Branches       2251     2570     +319     
============================================
+ Hits           6591     9241    +2650     
- Misses         4012     4960     +948     
- Partials       1140     1301     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review December 17, 2025 20:51
@andygrove andygrove changed the title feat: Initial implementation of size for array inputs [WIP] feat: Initial implementation of size for array inputs Dec 17, 2025
@comphead
Copy link
Contributor

@andygrove

- size with array input *** FAILED *** (738 milliseconds)

@andygrove
Copy link
Member Author

@comphead please take another look when you can

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove it is LGTM

@andygrove andygrove merged commit a122a14 into apache:main Dec 23, 2025
114 checks passed
@andygrove andygrove deleted the size branch December 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants