Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 13, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

There was no major reason for doing this, but it seems better to have a config rather than hard-coded values.

What changes are included in this PR?

How are these changes tested?

@andygrove andygrove marked this pull request as ready for review December 13, 2025 20:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.42%. Comparing base (f09f8af) to head (817e9f0).
⚠️ Report is 767 commits behind head on main.

Files with missing lines Patch % Lines
...on/src/main/scala/org/apache/comet/CometConf.scala 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2899      +/-   ##
============================================
+ Coverage     56.12%   59.42%   +3.29%     
- Complexity      976     1368     +392     
============================================
  Files           119      167      +48     
  Lines         11743    15351    +3608     
  Branches       2251     2546     +295     
============================================
+ Hits           6591     9122    +2531     
- Misses         4012     4943     +931     
- Partials       1140     1286     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove changed the title feat: Make shuffle writer buffer size configurable [WIP] feat: Make shuffle writer buffer size configurable Dec 13, 2025
"shuffle data to disk. Larger values may improve write performance by reducing " +
"the number of system calls, but will use more memory. " +
"The default is 1MB which provides a good balance between performance and memory usage.")
.intConf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use bytesConf?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @andygrove

Thanks @wForget for the feedback it makes sense. bytesConf can be useful if mostly talking the same levels like GB or MBs.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove

@andygrove andygrove merged commit 5ec12d4 into apache:main Dec 16, 2025
163 of 164 checks passed
@andygrove andygrove deleted the shuffle-write-bufsize branch December 16, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants