-
Notifications
You must be signed in to change notification settings - Fork 267
feat: Make shuffle writer buffer size configurable #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
============================================
+ Coverage 56.12% 59.42% +3.29%
- Complexity 976 1368 +392
============================================
Files 119 167 +48
Lines 11743 15351 +3608
Branches 2251 2546 +295
============================================
+ Hits 6591 9122 +2531
- Misses 4012 4943 +931
- Partials 1140 1286 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "shuffle data to disk. Larger values may improve write performance by reducing " + | ||
| "the number of system calls, but will use more memory. " + | ||
| "The default is 1MB which provides a good balance between performance and memory usage.") | ||
| .intConf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use bytesConf?
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @andygrove
Thanks @wForget for the feedback it makes sense. bytesConf can be useful if mostly talking the same levels like GB or MBs.
wForget
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove
Which issue does this PR close?
Closes #.
Rationale for this change
There was no major reason for doing this, but it seems better to have a config rather than hard-coded values.
What changes are included in this PR?
How are these changes tested?