-
Notifications
You must be signed in to change notification settings - Fork 260
fix: format decimal to string when casting to short #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4678d30 to
7a47424
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2916 +/- ##
============================================
+ Coverage 56.12% 59.62% +3.49%
- Complexity 976 1382 +406
============================================
Files 119 167 +48
Lines 11743 15492 +3749
Branches 2251 2568 +317
============================================
+ Hits 6591 9237 +2646
- Misses 4012 4955 +943
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ee82678 to
a4279f3
Compare
|
@rohitrastogi @andygrove Please help review when you find time. Thanks! |
| test("cast between decimals with higher precision than source") { | ||
| // cast between Decimal(10, 2) to Decimal(10,4) | ||
| castTest(generateDecimalsPrecision10Scale2(), DataTypes.createDecimalType(10, 4)) | ||
| castTest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manuzhang I pulled these test changes locally using latest from main branch and they pass for me, so I'm not sure that these tests reproduce the problem that the fix is intended to address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andygrove I've reworked my PR. Could you please check again?
a4279f3 to
e88e121
Compare
|
Failed test is not related to this PR. |
e88e121 to
9d1f22d
Compare
9d1f22d to
9064dfd
Compare
Which issue does this PR close?
Closes #2914.
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Updated CometCastSuite.