Skip to content

chore: deprecate native_comet scan in favor of native_iceberg_compat #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shekharrajak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: deprecate native_comet scan in favor of native_iceberg_compat #2949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a0cc6
chore: deprecate native_comet scan in favor of native_iceberg_compat
Shekharrajak Dec 20, 2025
4f9a5c6
Update common/src/main/scala/org/apache/comet/CometConf.scala
Shekharrajak Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions common/src/main/scala/org/apache/comet/CometConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)

// Deprecated: native_comet uses mutable buffers incompatible with Arrow FFI best practices
// and does not support complex types. Use native_iceberg_compat or auto instead.
// See: https://github.com/apache/datafusion-comet/issues/2186
@deprecated("Use SCAN_AUTO instead", "0.9.0")
val SCAN_NATIVE_COMET = "native_comet"
val SCAN_NATIVE_DATAFUSION = "native_datafusion"
val SCAN_NATIVE_ICEBERG_COMPAT = "native_iceberg_compat"
Expand All @@ -121,11 +125,11 @@ object CometConf extends ShimCometConf {
.doc(
s"The implementation of Comet Native Scan to use. Available modes are `$SCAN_NATIVE_COMET`," +
s"`$SCAN_NATIVE_DATAFUSION`, and `$SCAN_NATIVE_ICEBERG_COMPAT`. " +
s"`$SCAN_NATIVE_COMET` is for the original Comet native scan which uses a jvm based " +
"parquet file reader and native column decoding. Supports simple types only " +
s"`$SCAN_NATIVE_DATAFUSION` is a fully native implementation of scan based on DataFusion" +
s"`$SCAN_NATIVE_ICEBERG_COMPAT` is a native implementation that exposes apis to read " +
s"parquet columns natively. `$SCAN_AUTO` chooses the best scan.")
s"`$SCAN_NATIVE_COMET` (DEPRECATED) is for the original Comet native scan which uses a jvm based " +
"parquet file reader and native column decoding. Supports simple types only. " +
s"`$SCAN_NATIVE_DATAFUSION` is a fully native implementation of scan based on DataFusion. " +
s"`$SCAN_NATIVE_ICEBERG_COMPAT` is the recommended native implementation that exposes apis to read " +
s"parquet columns natively and supports complex types. `$SCAN_AUTO` (default) chooses the best scan.")
.internal()
.stringConf
.transform(_.toLowerCase(Locale.ROOT))
Expand Down
Loading