Skip to content

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Dec 22, 2025

Which issue does this PR close?

Found when working on #2929
Closes #2958 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@comphead comphead requested a review from andygrove December 22, 2025 21:53
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comphead

@andygrove
Copy link
Member

build failures are due to recent merge issue in main. I have PR to fix: #2962

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (f09f8af) to head (dbc0f92).
⚠️ Report is 793 commits behind head on main.

Files with missing lines Patch % Lines
...he/comet/rules/EliminateRedundantTransitions.scala 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2960      +/-   ##
============================================
+ Coverage     56.12%   59.60%   +3.47%     
- Complexity      976     1381     +405     
============================================
  Files           119      167      +48     
  Lines         11743    15494    +3751     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9235    +2644     
- Misses         4012     4958     +946     
- Partials       1140     1301     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove merged commit bba98c7 into apache:main Dec 23, 2025
168 of 169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Comet writer adds unnecessary transition CometColumnarToRow

3 participants