Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 23, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Cast String to Date:                      Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                               923            943          22         11.4          88.0       1.0X
Comet (Scan)                                       1064           1072          12          9.9         101.5       0.9X
Comet (Scan + Exec)                                 429            442          15         24.5          40.9       2.2X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Try_Cast String to Date:                  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                               921            941          33         11.4          87.9       1.0X
Comet (Scan)                                       1120           1125           6          9.4         106.8       0.8X
Comet (Scan + Exec)                                 428            451          18         24.5          40.8       2.2X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Cast String to Timestamp:                 Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                              1290           1296          10          8.1         123.0       1.0X
Comet (Scan)                                       1341           1377          51          7.8         127.9       1.0X
Comet (Scan + Exec)                                1348           1352           6          7.8         128.6       1.0X

OpenJDK 64-Bit Server VM 11.0.22+7-LTS on Mac OS X 14.6.1
Apple M3 Max
Try_Cast String to Timestamp:             Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                              1309           1327          25          8.0         124.8       1.0X
Comet (Scan)                                       1314           1316           3          8.0         125.3       1.0X
Comet (Scan + Exec)                                1372           1390          25          7.6         130.8       1.0X

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.59%. Comparing base (f09f8af) to head (6bc01da).
⚠️ Report is 799 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2980      +/-   ##
============================================
+ Coverage     56.12%   59.59%   +3.46%     
- Complexity      976     1376     +400     
============================================
  Files           119      167      +48     
  Lines         11743    15492    +3749     
  Branches       2251     2567     +316     
============================================
+ Hits           6591     9232    +2641     
- Misses         4012     4962     +950     
- Partials       1140     1298     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review December 23, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants