Skip to content

chore: CometConf change default batch size values #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
comphead wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: CometConf change default batch size values #3548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/src/main/scala/org/apache/comet/CometConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ object CometConf extends ShimCometConf {
.doc("The columnar batch size, i.e., the maximum number of rows that a batch can contain.")
.intConf
.checkValue(v => v > 0, "Batch size must be positive")
.createWithDefault(8192)
.createWithDefault(32768)

val COMET_COLUMNAR_SHUFFLE_BATCH_SIZE: ConfigEntry[Int] =
conf("spark.comet.columnar.shuffle.batch.size")
Expand All @@ -505,7 +505,7 @@ object CometConf extends ShimCometConf {
.checkValue(
v => v <= COMET_BATCH_SIZE.get(),
"Should not be larger than batch size `spark.comet.batchSize`")
.createWithDefault(8192)
.createWithDefault(32768)

val COMET_SHUFFLE_WRITE_BUFFER_SIZE: ConfigEntry[Long] =
conf(s"$COMET_EXEC_CONFIG_PREFIX.shuffle.writeBufferSize")
Expand Down
Loading