feat: support Set Comparison Subquery #19109
Open
+944
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
sql
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
kosiew
reviewed
Dec 25, 2025
Comment on lines
+59
to
+60
| async fn set_comparison_all_empty() -> Result<()> { | ||
| let ctx = SessionContext::new(); |
Contributor
There was a problem hiding this comment.
how about adding
async fn set_comparison_type_mismatch() -> Result<()> {
// SELECT v FROM t WHERE v > ANY (SELECT s FROM strings)
// INT > STRING should error with clear message
...
too?
| )?; | ||
|
|
||
| let df = ctx | ||
| .sql("select v from t where v < all(select v from e)") |
Contributor
There was a problem hiding this comment.
I think tests for:
- Multiple operators (
=,!=,>=,<=) - NULL semantics (e.g.,
5 != ALL (1, NULL)
would improve test coverage
Member
Author
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Support Set Comparison Subquery (or Quantified Comparison Subquery in some systems), it looks like
or
What changes are included in this PR?
ExprbranchExpr::SetComparisonand correspondingSetComparisonstructRewriteSetComparisonto translate this kind of subquery using existing componentsRewriteSetComparisonis a very naive implementation. We can optimize it in various ways in the follow-up PRs, like using min/max for non-equal comparison operators etc.Are these changes tested?
Yes, by unit test and slt
Are there any user-facing changes?
To SQL user, this is a new feature. To API user,
ExprPlanner::plan_anyis removed (not needed)