-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Store example data directly inside the datafusion-examples (#19141) #19319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cj-zhukov
wants to merge
14
commits into
apache:main
Choose a base branch
from
cj-zhukov:cj-zhukov/store-example-data-directly-inside-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,040
−368
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9e35cfe
Store example data directly inside the datafusion-examples (#19141)
6daedb6
run prettier
6603e3e
preserve file:// & fix comments
591f61c
replace aggregate_test_100.csv with cars.csv
d77de01
replace alltypes_plain.parquet with cars.csv
b02e636
Merge branch 'main' into cj-zhukov/store-example-data-directly-inside…
cj-zhukov 7d35fcc
fix fmt issues
e6b30ac
fix fmt issues
449f3aa
Fix issues causing GitHub checks to fail
7dc8a50
replace window_1.csv with cars.csv
fb1af66
remove window_1.csv
396193b
update README with files examples
40b1e60
update cache_factory example to use cars.csv instead of alltypes_plai…
445dbff
add cache_factory example in usage doc in main
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <!--- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| ## Example datasets | ||
|
|
||
| | Filename | Path | Description | | ||
| | ----------- | --------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ||
| | `cars.csv` | [`data/csv/cars.csv`](./csv/cars.csv) | Time-series–like dataset containing car identifiers, speed values, and timestamps. Used in window function and time-based query examples (e.g. ordering, window frames). | | ||
| | `regex.csv` | [`data/csv/regex.csv`](./csv/regex.csv) | Dataset for regular expression examples. Contains input values, regex patterns, replacement strings, and optional flags. Covers ASCII, Unicode, and locale-specific text processing. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| car,speed,time | ||
| red,20.0,1996-04-12T12:05:03.000000000 | ||
| red,20.3,1996-04-12T12:05:04.000000000 | ||
| red,21.4,1996-04-12T12:05:05.000000000 | ||
| red,21.5,1996-04-12T12:05:06.000000000 | ||
| red,19.0,1996-04-12T12:05:07.000000000 | ||
| red,18.0,1996-04-12T12:05:08.000000000 | ||
| red,17.0,1996-04-12T12:05:09.000000000 | ||
| red,7.0,1996-04-12T12:05:10.000000000 | ||
| red,7.1,1996-04-12T12:05:11.000000000 | ||
| red,7.2,1996-04-12T12:05:12.000000000 | ||
| red,3.0,1996-04-12T12:05:13.000000000 | ||
| red,1.0,1996-04-12T12:05:14.000000000 | ||
| red,0.0,1996-04-12T12:05:15.000000000 | ||
| green,10.0,1996-04-12T12:05:03.000000000 | ||
| green,10.3,1996-04-12T12:05:04.000000000 | ||
| green,10.4,1996-04-12T12:05:05.000000000 | ||
| green,10.5,1996-04-12T12:05:06.000000000 | ||
| green,11.0,1996-04-12T12:05:07.000000000 | ||
| green,12.0,1996-04-12T12:05:08.000000000 | ||
| green,14.0,1996-04-12T12:05:09.000000000 | ||
| green,15.0,1996-04-12T12:05:10.000000000 | ||
| green,15.1,1996-04-12T12:05:11.000000000 | ||
| green,15.2,1996-04-12T12:05:12.000000000 | ||
| green,8.0,1996-04-12T12:05:13.000000000 | ||
| green,2.0,1996-04-12T12:05:14.000000000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| values,patterns,replacement,flags | ||
| abc,^(a),bb\1bb,i | ||
| ABC,^(A).*,B,i | ||
| aBc,(b|d),e,i | ||
| AbC,(B|D),e, | ||
| aBC,^(b|c),d, | ||
| 4000,\b4([1-9]\d\d|\d[1-9]\d|\d\d[1-9])\b,xyz, | ||
| 4010,\b4([1-9]\d\d|\d[1-9]\d|\d\d[1-9])\b,xyz, | ||
| Düsseldorf,[\p{Letter}-]+,München, | ||
| Москва,[\p{L}-]+,Moscow, | ||
| Köln,[a-zA-Z]ö[a-zA-Z]{2},Koln, | ||
| اليوم,^\p{Arabic}+$,Today, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change this example to read in the cars.csv file and then write it back out as an encrypted parquet file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes sense.
I agree that using fewer, clearer datasets in the examples is a good direction. I can look into rewriting this
parquet_encryptedexample to read fromcars.csvand then write the encrypted parquet output, instead of relying onalltypes_plain.parquet.I’ll prototype that approach and report back once I confirm everything works cleanly with the encryption workflow.