Replace deprecated structopt with clap in datafusion-benchmarks #19492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes - #19482
(Part of #19072 )
Rationale for this change
The structopt crate is deprecated and has been superseded by clap with its derive feature.
This migration:
What changes are included in this PR?
Updated Cargo.toml to use clap = { version = "4.5.53", features = ["derive"] } instead of structopt
Migrated all benchmark source files to use clap's derive macros:
#[derive(StructOpt)]→#[derive(Parser/Args/Subcommand)]#[structopt(...)]→#[arg(...)]for fields#[structopt(...)]→#[command(...)]for struct/enum-level attributesStructOpt::from_args()→Parser::parse()Removed
parse(from_os_str)as PathBuf works natively in clapChanged short flag strings to chars ('p' instead of "p")
Are these changes tested?
Yes
Are there any user-facing changes?
No. The CLI interface remains identical - this is a drop-in replacement of the underlying argument parsing library.