chore(deps): Update sqlparser to 0.60 #19672
Conversation
github-actions
bot
added
sql
|
Could we address the CI failures? Looks like some tests are failing |
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Standing-Man
force-pushed
the
sqlparser-upgrade
branch
from
0ea9df1 to
c2dd55b
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
@Jefffrey ready to review. |
|
I was literally about to sit down and have codex try to do this -- thank you @Standing-Man -- taking a look now |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me @Standing-Man -- thank you. THe only question I have is about the change of API to use Boxed results
| pub enum RelationPlanning { | ||
| /// The relation was successfully planned by an extension planner | ||
| Planned(PlannedRelation), | ||
| Planned(Box<PlannedRelation>), |
There was a problem hiding this comment.
Why is this API changed?
I think this is a breaking API change, so there should be a good reason for doing so
There was a problem hiding this comment.
Without this breaking API change, the Clippy check would warn with clippy::large-enum-variant, indicating that the entire enum is at least 624 bytes.
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @Standing-Man and @Jefffrey
3 participants
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?