[Feature](function) Support function cross_product of DuckDB by juruo-c · Pull Request #59223 · apache/doris

juruo-c · 2025-12-21T14:11:13Z

What problem does this PR solve?

Issue Number: #48203

Related PR: #xxx

Problem Summary:

Release note

doc: apache/doris-website#3209
The CROSS_PRODUCT function is used to compute the cross product of two arrays of size 3.

SELECT CROSS_PRODUCT([1, 2, 3], [2, 3, 4]), CROSS_PRODUCT([1, 0, 0], [0, 1, 0]);

+-------------------------------------+-------------------------------------+
| CROSS_PRODUCT([1, 2, 3], [2, 3, 4]) | CROSS_PRODUCT([1, 0, 0], [0, 1, 0]) |
+-------------------------------------+-------------------------------------+
| [-1, 2, -1]                         | [0, 0, 1]                           |
+-------------------------------------+-------------------------------------+

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes. [Feature](function) Support function cross_product of DuckDB doris-website#3209

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-12-21T14:11:19Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

...-test/suites/query_p0/sql_functions/array_functions/test_array_cross_product_function.groovy

.../src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CrossProduct.java

be/src/vec/functions/array/function_array_cross_product.cpp

zclllyybb · 2025-12-21T14:19:22Z

be/src/vec/functions/array/function_array_cross_product.h

+        const auto& arg1 = block.get_by_position(arguments[0]);
+        const auto& arg2 = block.get_by_position(arguments[1]);
+
+        auto col1 = arg1.column->convert_to_full_column_if_const();


use vector_const and const_vector to deal constancy

I want to confirm my understanding:
should I explicitly handle ColumnConst instead of calling convert_to_full_column_if_const()?
If my understanding is incorrect, I would appreciate your guidance on how to handle this.

yes. convert_to_full_column_if_const will lead to performance problem

be/src/vec/functions/array/function_array_cross_product.h

zclllyybb · 2025-12-21T14:25:50Z

be/src/vec/functions/array/function_array_cross_product.h

+                        get_name(), size1, size2);
+            }
+
+            if (size1 != 3 || size2 != 3) {


L156 and L162 are same check?

I don't think so. One ensures length consistency between the two inputs, while the other enforces a fixed-size 3 requirement.

I mean, if if (size1 != 3 || size2 != 3) get false, then if (size1 != size2) must be false, right? they are entailment relationship. so just remove the first.

be/src/vec/functions/array/function_array_cross_product.h

zclllyybb · 2025-12-21T14:29:06Z

and remember to format your code ~

.../src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CrossProduct.java

zclllyybb

Hi, there's still some problem. besides some reply of previous comments

be/src/vec/functions/array/function_array_cross_product.cpp

zclllyybb · 2026-01-15T11:04:25Z

be/src/vec/functions/array/function_array_cross_product.cpp

+
+        if (arr1->get_data_ptr()->is_nullable()) {
+            if (arr1->get_data_ptr()->has_null()) {
+                throw doris::Exception(ErrorCode::INVALID_ARGUMENT,


replace all throw with return status in this function

zclllyybb · 2026-01-15T11:07:00Z

be/src/vec/functions/array/function_array_cross_product.h

+                        get_name(), size1, size2);
+            }
+
+            if (size1 != 3 || size2 != 3) {


I mean, if if (size1 != 3 || size2 != 3) get false, then if (size1 != size2) must be false, right? they are entailment relationship. so just remove the first.

HappenLee · 2026-01-17T16:01:12Z

be/src/vec/functions/array/function_array_cross_product.cpp

+                                   "Arguments for function {} must be arrays", get_name());
+        }
+
+        // return ARRAY<DOUBLE>


why not the array float recheck the duckdb logic ?

HappenLee · 2026-01-18T16:52:30Z

be/src/vec/functions/array/function_array_cross_product.cpp

+                        "Second argument for function {} cannot have null elements", get_name());
+            }
+            auto nullable2 = assert_cast<const ColumnNullable*>(arr2->get_data_ptr().get());
+            float2 = assert_cast<const ColumnFloat64*>(nullable2->get_nested_column_ptr().get());


should dispose the nullable2 value is null case, it the value is null, the float2 maybe have invalid element

zclllyybb

Here's still an important thing: by default implementation framework of nulls, we unwrap nullmap and directly send nested column to function's impl. if there's a check of nested value validity in your function (size=3), it will be false positive alarm. so in this function you should deal null without our default framework. like #59897.

[Feature](function) Support function cross_product of DuckDB

8be85db

juruo-c requested a review from zclllyybb as a code owner December 21, 2025 14:11

zclllyybb self-assigned this Dec 21, 2025

zclllyybb reviewed Dec 21, 2025

View reviewed changes

zclllyybb added the dev/4.0.x label Dec 21, 2025

Mryange reviewed Dec 23, 2025

View reviewed changes

.../src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CrossProduct.java Outdated Show resolved Hide resolved

Mryange reviewed Dec 23, 2025

View reviewed changes

.../src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CrossProduct.java Outdated Show resolved Hide resolved

juruo-c force-pushed the feature/array-cross-product branch from 3e5e023 to 58fb654 Compare January 15, 2026 01:01

zclllyybb reviewed Jan 15, 2026

View reviewed changes

juruo-c force-pushed the feature/array-cross-product branch from 58fb654 to c0b84d3 Compare January 16, 2026 01:12

fix some error and add table test

402901b

juruo-c force-pushed the feature/array-cross-product branch from c0b84d3 to 402901b Compare January 16, 2026 01:15

HappenLee reviewed Jan 17, 2026

View reviewed changes

HappenLee reviewed Jan 18, 2026

View reviewed changes

zclllyybb requested changes Jan 18, 2026

View reviewed changes

Conversation

juruo-c commented Dec 21, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Dec 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zclllyybb commented Dec 21, 2025

Uh oh!

Uh oh!

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HappenLee Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HappenLee Jan 17, 2026 •

edited

Loading