[fix](filecache) reset_range dose not update shadow queue causing lar…#60555
Open
freemandealer wants to merge 1 commit intoapache:branch-3.1from
Open
[fix](filecache) reset_range dose not update shadow queue causing lar…#60555freemandealer wants to merge 1 commit intoapache:branch-3.1from
freemandealer wants to merge 1 commit intoapache:branch-3.1from
Conversation
…ge cache size pick#59314 pick apache#59314 shadown queue is copying the actual LRU queue and provide lockless acess. but the copying loses updating size wh en actual LRU queue is reseting range (when load data, we first allocate 1MB block for the data and reset the size t o the real size when finalizing). This commit does the following to fix this problem: 1. update the corresponding shadow queue element when resetting 2. calibrate size during initial loading into memory process Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ge cache size pick#59314
pick #59314
shadown queue is copying the actual LRU queue and provide lockless acess. but the copying loses updating size wh en actual LRU queue is reseting range (when load data, we first allocate 1MB block for the data and reset the size t o the real size when finalizing).
This commit does the following to fix this problem:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)